dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 286 forks source link

Code Health | Remove unused/unreferenced files #3008

Closed edwardneal closed 3 days ago

edwardneal commented 3 days ago

This is largely cleanup from earlier PRs - four files are no longer used:

Not essential for preview3, although I don't see it having any impact if included (beyond review time!)

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.47%. Comparing base (5744b51) to head (9c64f17). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3008 +/- ## ========================================== + Coverage 72.45% 72.47% +0.02% ========================================== Files 288 287 -1 Lines 59493 59474 -19 ========================================== + Hits 43104 43106 +2 + Misses 16389 16368 -21 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/3008/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/3008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.58% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/3008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.41% <ø> (+0.03%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/3008/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.91% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.