dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 286 forks source link

Cleanup | Move SniErrors to be uint #3017

Open benrr101 opened 20 hours ago

benrr101 commented 20 hours ago

Description: This is a fairly small change to avoid casting SNI error codes to int as much as possible. The error codes are uint and can be treated as such in most situations.

The other change here is to clean up the CreateLocalDbException methods to drop unnecessary arguments. This kinda sets me up for failure when merging LocalDBAPI, buuuuuut that's a risk I'm willing to take.

Testing: Builds still work just fine, and there's no real change to functionality.