dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
859 stars 288 forks source link

Merge | Remove RelationshipConverter #3023

Open benrr101 opened 2 days ago

benrr101 commented 2 days ago

Description: This class isn't being used - we should delete it! 🚮

Testing: Project builds just fine without, should be good to delete.

... Is this a merge PR or a cleanup PR. I mean I'm technically merging it into the great codebase in the sky (and I don't just mean the cloud), and we're consolidating it between netfx and netcore (that doesn't have it)

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.70%. Comparing base (1b9df10) to head (e1503ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3023 +/- ## ========================================== + Coverage 72.64% 72.70% +0.05% ========================================== Files 285 284 -1 Lines 59160 59155 -5 ========================================== + Hits 42979 43008 +29 + Misses 16181 16147 -34 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/3023/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/3023/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.58% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/3023/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.42% <ø> (+0.03%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/3023/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `71.14% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: