Open MichelZ opened 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.68%. Comparing base (
b1f7eaf
) to head (4ab317f
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
AI Blurp
This pull request includes changes to the
BatchTests.cs
file to add retry logic for SQL commands and to enhance theSqlBatchCommand
functionality. The most important changes are as follows:Enhancements to SQL retry logic:
SqlRetryLogicOption
andSqlRetryLogicBaseProvider
to handle transient errors like deadlocks by retrying the operation up to three times with a delay of 100 milliseconds.Improvements to
SqlBatchCommand
:StoredProcedureBatchSupported
andMixedBatchSupported
methods to include parameters inSqlBatchCommand
for executing stored procedures, specifically adding a parameter for thesp_help
stored procedure.Additional imports:
System.Collections.Generic
import to support the use ofList<SqlParameter>
in the updated methods.Description
I regularly see deadlocks for the tests that use
sp_help
. I'll try to mitigate this in 2 different ways:@objname
that does less work so it's less likely to get a deadlockIt can probably also be solved by just using another stored procedure that's not prone to deadlocks, but I chose this way as the easiest path
Example test failure: https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=101959&view=logs&j=700ebecb-e440-5400-66bb-488206e790af&t=d8ae6a68-b967-5b1e-ef3d-1b53d82075ee&l=826