dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
859 stars 288 forks source link

Improve timeout of tests #3026

Open MichelZ opened 1 day ago

MichelZ commented 1 day ago

AI Blurp

This pull request includes changes to improve the reliability of connection tests by adjusting connection timeouts. The most important changes include setting a minimum connection timeout in the ConversionTests and EventCounterTest classes.

Improvements to connection tests:

Description

There are quite a few test failures on these methods: https://sqlclientdrivers.visualstudio.com/public/_test/analytics?definitionId=1879&contextType=build

Many of the failures are timeouts, so I'm trying to see if increasing the timeout a bit could help make these tests more stable

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.71%. Comparing base (b1f7eaf) to head (a063ec4). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3026 +/- ## ========================================== + Coverage 72.68% 72.71% +0.02% ========================================== Files 285 285 Lines 59155 59160 +5 ========================================== + Hits 42998 43017 +19 + Misses 16157 16143 -14 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/3026/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/3026/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.58% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/3026/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.44% <ø> (+0.05%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/3026/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `71.13% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: