Open MichelZ opened 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.71%. Comparing base (
b1f7eaf
) to head (a063ec4
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
AI Blurp
This pull request includes changes to improve the reliability of connection tests by adjusting connection timeouts. The most important changes include setting a minimum connection timeout in the
ConversionTests
andEventCounterTest
classes.Improvements to connection tests:
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ConversionTests.cs
: Adjusted the connection timeout to a minimum of 30 seconds in thepublic ConversionTests()
method to reduce the likelihood of connection timeouts during tests.src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/EventCounterTest.cs
: Added a minimum connection timeout of 30 seconds in thepublic void EventCounter_ReclaimedConnectionsCounter_Functional()
method to ensure consistent test execution.Description
There are quite a few test failures on these methods: https://sqlclientdrivers.visualstudio.com/public/_test/analytics?definitionId=1879&contextType=build
Many of the failures are timeouts, so I'm trying to see if increasing the timeout a bit could help make these tests more stable