search

dotnet / TorchSharp

A .NET library that provides access to the library that powers PyTorch.
MIT License
1.37k stars 177 forks source link

Remove NetFX build from this repo #128

Closed dsyme closed 4 years ago

dsyme commented 4 years ago

I think we should remove the .NET Framework build from this repo, in aid of simplification, and just focus on .NET Core.

@interesaaat @migueldeicaza That ok?

dsyme commented 4 years ago

@interesaaat Just to let you know that @migueldeicaza has granted me co-maintainer rights in this repo and for the nuget packages

My aim is limited - to get to the point where we can use the libtorch tensor implementation as the backend for DiffSharp, see https://github.com/DiffSharp/DiffSharp/pull/106. Roughly I expect this will mean:

interesaaat commented 4 years ago

I am all for it!

migueldeicaza commented 4 years ago

Sure - it is just that .NET Core is still slower to build/debug than .NET Framework is on Mac, hence why I prefer those. But I am not working on this anymore, so up to you Don.

gbaydin commented 4 years ago

@interesaaat Just to let you know that @migueldeicaza has granted me co-maintainer rights in this repo and for the nuget packages

My aim is limited - to get to the point where we can use the libtorch tensor implementation as the backend for DiffSharp, see DiffSharp/DiffSharp#106. Roughly I expect this will mean:

  • [ ] Get changes such as #127
  • [ ] Update the nuget packages
  • [ ] Update TorchSharp to more recent pytorch redist
  • [ ] Simplify TorchSharp where it makes sense for a long term trajectory (e.g. this issue)

This is awesome!