MacOS build fails after merge into master

[NiklasGustafsson]

After merging, the MacOS Release build fails during tests. Same thing happens on my Mac if I run tests for the 'Release' build.

[NiklasGustafsson]

From the build log:

EXEC : error : /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: no LC_RPATH load command with path: /usr/local/lib found in: /Users/runner/work/1/s/src/Native/../../bin/x64.Release/Native/./libLibTorchSharp.dylib (for architecture x86_64), required for specified option "-delete_rpath /usr/local/lib" [/Users/runner/work/1/s/src/Native/build.proj]
EXEC : error : /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: no LC_RPATH load command with path: /usr/local/opt/llvm/lib found in: /Users/runner/work/1/s/src/Native/../../bin/x64.Release/Native/./libLibTorchSharp.dylib (for architecture x86_64), required for specified option "-delete_rpath /usr/local/opt/llvm/lib" [/Users/runner/work/1/s/src/Native/build.proj]
EXEC : error : /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: no LC_RPATH load command with path: /Users/runner/work/1/s/bin/obj/AnyCPU.Release/libtorch-cpu/libtorch-macos-1.8.0cpu/libtorch/lib found in: /Users/runner/work/1/s/src/Native/../../bin/x64.Release/Native/./libLibTorchSharp.dylib (for architecture x86_64), required for specified option "-delete_rpath /Users/runner/work/1/s/bin/obj/AnyCPU.Release/libtorch-cpu/libtorch-macos-1.8.0cpu/libtorch/lib" [/Users/runner/work/1/s/src/Native/build.proj]
EXEC : error : /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: for: /Users/runner/work/1/s/src/Native/../../bin/x64.Release/Native/./libLibTorchSharp.dylib (for architecture x86_64) option "-add_rpath @loader_path" would duplicate path, file already has LC_RPATH for: @loader_path [/Users/runner/work/1/s/src/Native/build.proj]
EXEC : error : /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: for: /Users/runner/work/1/s/src/Native/../../bin/x64.Release/Native/./libLibTorchSharp.dylib (for architecture x86_64) option "-add_rpath @executable_path" would duplicate path, file already has LC_RPATH for: @executable_path [/Users/runner/work/1/s/src/Native/build.proj]
/Users/runner/work/1/s/src/Native/build.proj(40,5): error MSB3073: The command ""/Users/runner/work/1/s/src/Native/build.sh" --configuration Release --arch x64  --libtorchpath /Users/runner/work/1/s/bin/obj/AnyCPU.Release/libtorch-cpu/libtorch-macos-1.8.0cpu/libtorch/share/cmake/Torch" exited with code -1.

[dsyme]

Hmmm ok, yes I only ran tests debug. I wonder why CI passes tests

On master build, I'm fixing the package build, see direct commits like https://github.com/xamarin/TorchSharp/commit/33a690609cd2255257da6e172a57bec799d7b3a9

[NiklasGustafsson]

Yes, it is very curious that it works on the PR build, but not on the master build or on my machine.

[dsyme]

Master build passed MacOS release tests, it failed later in the package build

[NiklasGustafsson]

Release tests run on my machine, now.