dotnet / TorchSharp

A .NET library that provides access to the library that powers PyTorch.
MIT License
1.37k stars 177 forks source link

Create unit tests for all API bindings. #33

Closed NiklasGustafsson closed 4 years ago

NiklasGustafsson commented 5 years ago

We should create unit tests for all the API bindings.

interesaaat commented 5 years ago

Connected with this, we should also refactor the structure of the project with Tester moved to Sample, Test containing unit tests. I also would like to have a solution structure similar to ML.NET with src and test dirs, src containing TorchSharp (and TorchTensor) and Samples, and test containing the tests.

NiklasGustafsson commented 5 years ago

I agree with that. Maybe also come up with a more official-sounding hierarchical namespace while we're at it (since it typically affects the folder structure). The libtorch bindings will be the low-level API that everything else uses, so it should perhaps not be in the top-level namespace.

interesaaat commented 5 years ago

Totally agree.

dsyme commented 4 years ago

Closing as specifically ATen related, see https://github.com/xamarin/TorchSharp/pull/129