search

dotnet / TorchSharp

A .NET library that provides access to the library that powers PyTorch.
MIT License
1.37k stars 177 forks source link

Enable API Compat for TorchSharp #681

Closed ericstj closed 3 months ago

ericstj commented 2 years ago

Can we enable API Compat for TorchSharp? It’s part of the .NET SDK since 6.0.

Enabling it can be done with these steps: .NET Package Validation - .NET | Microsoft Docs

This will help flag when changes are made that would break the API surface. You can still choose to make those changes if you want to suppress the errors, but this will make it clear when breaking changes are made.

NiklasGustafsson commented 2 years ago

Sounds like a great idea. Can I talk you into volunteering to do it? :-)

NiklasGustafsson commented 3 months ago

@ericstj, is this still something you want us to pursue?

ericstj commented 3 months ago

Sure, I'll submit a change that does it.