dotnet / TorchSharpExamples

Repository for TorchSharp examples and tutorials.
MIT License
129 stars 47 forks source link

str function doesn't appear to perform optional argument resolution as described. #25

Closed collinkruger closed 2 years ago

collinkruger commented 2 years ago

Hi 👋

A few tutorials make use of the str method. It appears a recent change to TorchSharp breaks optional argument resolution.

These two tutorials make use of str https://github.com/dotnet/TorchSharpExamples/blob/main/tutorials/FSharp/tutorial2.ipynb https://github.com/dotnet/TorchSharpExamples/blob/main/tutorials/CSharp/tutorial2.ipynb

Here is a minimal example image

I've also opened an issue in the TorchSharp repo. https://github.com/dotnet/TorchSharp/issues/628

NiklasGustafsson commented 2 years ago

Thank you for reporting this. You are right, we inadvertently introduced a breaking change by adding the style argument before already existing arguments, which messes up position-based call sites.