search

dotnet / android

.NET for Android provides open-source bindings of the Android SDK for use with .NET managed languages such as C#
MIT License
1.89k stars 525 forks source link

Please update xamarin-android to consume zlib-ng from dotnet/runtime #9082

Open carlossanlop opened 3 days ago

carlossanlop commented 3 days ago

Android framework version

net9.0-android

Affected platform version

All

Description

The dotnet/runtime repo has migrated from consuming madler/zlib and zlib-intel to consuming zlib-ng. We merged this PR on 7/2 to achieve that: https://github.com/dotnet/runtime/issues/101465

The main issue tracking this migration effort is https://github.com/dotnet/runtime/issues/101465

In consequence, xamarin-macios and xamarin-android might need to make changes to ensure they retarget their dependencies appopriately.

Note: We ensured that mobile platforms find and consume the system-installed zlib, but are going to delete the zlib and zlib-intel references from the repo. So please help determine if you need to take actions on this repo.

This needs to be done before .NET 9 gets published.

Please let @carlossanlop or @akoeplinger know if you have any questions.

Steps to Reproduce

-

Did you find any workaround?

-

Relevant log output

-
dellis1972 commented 3 days ago

@grendello LibZipSharp ises zlib-ng already doesn't it? Not sure we use it anywhere else?

grendello commented 3 days ago

@dellis1972 it supports it, but we use zlib for now. There's a draft PR I need to go back to. But LibZipSharp uses its own copies of everything, due to the way it builds its support library.

I don't think we use zlib anywhere here anymore.