search

dotnet / android

.NET for Android provides open-source bindings of the Android SDK for use with .NET managed languages such as C#
MIT License
1.92k stars 526 forks source link

[Xamarin.Android.Build.Tasks] remove `$(_InstantRunEnabled)` checks #9292

Closed jonathanpeppers closed 1 week ago

jonathanpeppers commented 1 week ago

Context: https://github.com/xamarin/monodroid/commit/93ab95e18077d56d9d55ce7b4069a534e2dea35e Context: https://github.com/xamarin/monodroid/commit/2c64cd5f533616ff4751fb1df6bbfc7e170477ae

"Enhanced Fast Deployment" was removed from our private sources, so we can now remove the following from our MSBuild logic:

For one parameter of <GenerateJavaStubs/>, I created a private property $(_AndroidGenerateNativeAssembly) that defaults to true.

In a future PR, we could consider making runtime changes to remove instant_run_enabled as well.

grendello commented 1 week ago

Once this PR is merged I'll open another one to update the native runtime accordingly.

grendello commented 1 week ago

Native runtime PR: https://github.com/dotnet/android/pull/9297