search

dotnet / android

.NET for Android provides open-source bindings of the Android SDK for use with .NET managed languages such as C#
MIT License
1.94k stars 533 forks source link

Building a Maui App for Android is extremely slow when EmbedAssembliesIntoApk is enabled (net9) #9455

Open AlexanderEgorov opened 1 month ago

AlexanderEgorov commented 1 month ago

Description

Building a MAUI project targeting net9.0-android is much slower when EmbedAssembliesIntoApk is enabled compared to building under net8.0-android (500s in net9 vs 90s in net8). Most of the time is spent on the _BuildApkEmbed process.

Steps to Reproduce

  1. Create a new application with dotnet new maui -n MauiBlankApp targeting net9.
  2. Build it with the following command: dotnet build MauiBlankApp.csproj -p:Configuration=Debug -p:TargetFramework=net9.0-android -p:EmbedAssembliesIntoApk=true -p:AndroidSdkDirectory=...

Link to public reproduction project repository

No response

Version with bug

9.0.0-rc.2.24503.2

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.92 SR9.2

Affected platforms

Android

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

jpobst commented 1 month ago

Can you create a .binlog for each one so we can compare the differences?

Run the command line again with -bl to create a msbuild.binlog in the current directory.

jonathanpeppers commented 1 month ago

Why do you have EmbedAssembliesIntoApk enabled? The feature called “fast deployment” is disabled by this setting.

AlexanderEgorov commented 1 month ago

Why do you have EmbedAssembliesIntoApk enabled? The feature called “fast deployment” is disabled by this setting.

We have a test server which builds apk's, and then run it with our own script on emulators and real phones. But even using locally, our team prefer building with the EmbedAssembliesIntoApk option enabled, because it works more reliable.

We noticed some optimizations in the build process based on the resultant APK file size compared to net8. However, we would like to be able to disable these optimizations in Debug mode to get a faster build like it was in net8.

Can you create a .binlog for each one so we can compare the differences?

net8: https://github.com/AlexanderEgorov/dotnet-android--9455/blob/main/MauiBlankApp_net8/msbuild.binlog net9: https://github.com/AlexanderEgorov/dotnet-android--9455/blob/main/MauiBlankApp_net9/msbuild.binlog

JaneySprings commented 1 month ago

Hi @jonathanpeppers ! I'm a developer of the .NET Meteor extension for VSCode. I also use this property for the debugging Android applications: https://github.com/JaneySprings/DotNet.Meteor/blob/e4a567de61061f07d74fc28db83187297de01bcc/src/VSCode.Extension/providers/dotnetTaskProvider.ts#L30

I tried to support the _FastDev feature, but internal testing showed that it works very unstable.

I also want the build and launch processes to be the same, both for iOS or Maccatalyst or Windows, and for Android.

dellis1972 commented 1 month ago

In what way is the FastDev features "unstable" ? It would be helpful to have more information as to why ? Is it a problem in our side or adb errors?

Turning FastDev off is always going to be slower because we have to not only build the apk from scratch, we also have to uninstall the app on the device before sending over the new one. All of this adds up.

JaneySprings commented 1 month ago

we also have to uninstall the app on the device before sending over the new one

As @AlexanderEgorov said, we don't use the dotnet -t:Run command. We are having problems with the build time of the apk file.

In what way is the FastDev features "unstable"

It works ~40% cases, but more often it doesn't. Sometimes an application shows '.NET' splashscreen for 2-3min and closes. Sometimes it shows me a main page, but debugging doesn't work. I see many adbd: connection refused messages in the logcat.

In the .NET Meteor extension I use the manual way:

This method has been working for more than two years on all operating systems (Linux, MacOS, Windows) and for every platform (Maccatalyst, iOS, Windows, Android).

jonathanpeppers commented 1 month ago

@JaneySprings we'd prefer if you could share a .binlog of the failures with fast deployment, and we should fix those instead: https://aka.ms/binlog

We'd prefer to fix that feature than improve a sub-optimal settings that fewer developers are using by default. Most of our developers just use the defaults (all settings just blank) inside Visual Studio.