search

dotnet / android

.NET for Android provides open-source bindings of the Android SDK for use with .NET managed languages such as C#
MIT License
1.93k stars 532 forks source link

Bump com.android.tools.build:manifest-merger from 30.3.1 to 31.7.2 in /src/manifestmerger #9500

Closed dependabot[bot] closed 2 days ago

dependabot[bot] commented 1 week ago

Bumps com.android.tools.build:manifest-merger from 30.3.1 to 31.7.2.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
jonathanpeppers commented 1 week ago

I think we need to bump gradle to fix this one now:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
jonathanpeppers commented 1 week ago

Ok, the jar task didn't get the Java version passed in, and failed with:

Could not determine the dependencies of task ':jar'.
> Could not resolve all files for configuration ':runtimeClasspath'.
   > Could not resolve com.android.tools.build:manifest-merger:31.7.2.
        > Dependency resolution is looking for a library compatible with JVM runtime version 8, but 'com.android.tools.build:manifest-merger:31.7.2' is only compatible with JVM runtime version 11 or newer.

I pushed a change that seems to fix it.

jonathanpeppers commented 2 days ago

I think this is currently broken because the branch name is so long:

/Users/builder/azdo/_work/7/s/xamarin-android/bin/Release/dotnet/sdk/9.0.100-rtm.24512.1/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5123: Warning As Error: The file 'package/services/metadata/core-properties/8ad2599f6a9642f9be51b1ddade15adf.psmdcp' path, name, or both are too long. Your package might not work without long file path support. Please shorten the file path or file name. [/Users/builder/azdo/_work/7/s/xamarin-android/build-tools/create-packs/Microsoft.Android.Sdk.proj] [/Users/builder/azdo/_work/7/s/xamarin-android/build-tools/create-packs/Microsoft.Android.Sdk.proj]
...
  The package Microsoft.Android.Sdk.Darwin.35.99.0-ci.dependabot-gradle-src-manifestmerger-com-android-tools-build-manifest-merger-31-7-2.28 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.

Microsoft.Android.Sdk.Darwin.35.99.0-ci.dependabot-gradle-src-manifestmerger-com-android-tools-build-manifest-merger-31-7-2.28 is a mouthfull!

jonathanpeppers commented 2 days ago

Closing in favor of https://github.com/dotnet/android/pull/9528

dependabot[bot] commented 2 days ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.