search

dotnet / arcade-services

Arcade Engineering Services
MIT License
60 stars 74 forks source link

Merge PR generator should support private repos #2358

Open mmitche opened 3 years ago

mmitche commented 3 years ago

https://dev.azure.com/dnceng/internal/_build?definitionId=350&_a=summary doesn't currently support private repos. This is blocking winforms-designer's merge PR generation. We could extend this pipeline out to use credentials (like the mirror bot does).

riarenas commented 3 years ago

I don't know where this would fit. If there's a blocked scenario maybe FR? but the blocked scenario is just convenience so I'm not quite sure it meets the bar.

mmitche commented 3 years ago

It's unclear how painful doing the merges manually is right now. I think it would go in FR if anything. @Shyam-Gupta for comment.

markwilkie commented 3 years ago

@Shyam-Gupta ?

Shyam-Gupta commented 3 years ago

@DustinCampbell, @merriemcgaw: Requesting your inputs on this.

/cc: @Pilchie

Pilchie commented 3 years ago

It's usually not a huge issue, but given VS's branching between 16.10, 16.11, and 17, there are quite a lot of branches and merges to manage at the moment.

MattGal commented 3 years ago

[Async Triage] : Doesn't smell like FR, I don't know where it'd be homed though.

jakubstilec commented 3 years ago

[Async Triage]: Created a teams chat: https://teams.microsoft.com/l/message/19:f9bc826d88fe4e52a0c84c0a4bc8577f@thread.skype/1622106153059?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=147df318-61de-4f04-8f7b-ecd328c256bb&parentMessageId=1622106153059&teamName=.NET%20Eng%20Services&channelName=Triage&createdTime=1622106153059

mmitche commented 3 years ago

It might be FR. It should be pretty simple to fix (just update the initial clone step to use credentials, like the mirror pipelines do)

MattGal commented 3 years ago

[Async Triage]: Doesn't meet the charter for FR but I agree it's pretty straightforward, so I'd be OK handling it there. @ilyas1974 ?

ilyas1974 commented 3 years ago

We should have bandwidth in FR to handle this request.

ChadNedzlek commented 3 years ago

@ilyas1974 Since it's been months, I don't think FR has the bandwidth to do this. And since it doesn't fit that charter, that means it probably needs to go. I'm punting it out.

jakubstilec commented 3 years ago

[Async Triage]: @lukas-lansky you have assigned it to yourself for a bit. Please don't you any update about it?

jakubstilec commented 3 years ago

[Async Triage]: ping @lukas-lansky

markwilkie commented 3 years ago

Moving to dotnet/arcade-services#2359