[darc/maestro++] Maestro should always be able to auto-merge update PRs

dotnet / arcade-services

Arcade Engineering Services

MIT License

60 stars 74 forks source link

[darc/maestro++] Maestro should always be able to auto-merge update PRs #2567

Open mmitche opened 5 years ago

mmitche commented 5 years ago

Because Maestro is an app today, it only has R/W permissions to repos. If a repository has required reviewers on the repo or has restricted the users who can push to a branch, it is unable to merge automatically. Find a way to enable auto-merging even in these cases. Some ideas:

Use a bot account rather than an app (bot account would need to be admin)
Convince github to add permissions to an app so it can merge around policy

jcagme commented 5 years ago

@mmitche I remember we talked about this a couple of weeks ago and the outcome was that we should respect repo's constrains. An example of this is https://github.com/dotnet/winforms-designer/pull/49.

zsd4yr commented 5 years ago

To chime in on our decision to not automerge, we wished to confirm all changes entering our repository. If it passes the CI and we approve it (satisfies our check to require review from codeowners), then it might be nice to auto-merge in. But we would like to keep reviewing these PRs before they go in

zsd4yr commented 5 years ago

Coming back around to this: we'd love to have this :)

mmitche commented 5 years ago

@zsd4yr Should be in the rollout happening today. @riarenas made it happen.

riarenas commented 5 years ago

Sadly that was only for AzDo repos. @zsd4yr wants it to work for Github as well.

AdamYoblick commented 5 years ago

/cc @dotnet/wpf-developers , @dotnet/dotnet-winforms , @vatsan-madhavan

riarenas commented 4 years ago

Might be necessary for the dependency flow without using PRs