Fixed a bug that prevents customers from updating the Source-enabled parameter on the subscription level - Githubissues

dotnet / arcade-services

Arcade Engineering Services

MIT License

53 stars 74 forks source link

Fixed a bug that prevents customers from updating the Source-enabled parameter on the subscription level #3542

Closed andriipatsula closed 3 months ago

andriipatsula commented 3 months ago

https://github.com/dotnet/arcade-services/issues/3540

The difference between the cli interface and the popup interface is that when you set sourceEnabled to False in the popUp interface, both SourceDirectory and TargetDirectory are set to null arcade-services/src/Microsoft.DotNet.Darc/Darc/Models/PopUps/SubscriptionPopUp.cs at main · dotnet/arcade-services (github.com)

Then, in arcade-services/src/Maestro/Maestro.Web/Api/v2020_02_20/Controllers/SubscriptionsController.cs at main · dotnet/arcade-services (github.com) we see that both SourceDirectory and TargetDirectory are null and return a BadRequest.

arcade-services/src/Maestro/Maestro.Web/Api/v2020_02_20/Controllers/SubscriptionsController.cs at main · dotnet/arcade-services (github.com) <-- here we are setting both SourceDirectory and TargetDirectory to null anyway.

Release Note Category

[ ] Feature changes/additions
[x] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

Fixed a bug that prevents customers from updating the Source-enabled parameter on the subscription level.

oleksandr-didyk commented 3 months ago

Rolled out by https://github.com/dotnet/arcade-services/issues/3545