search

dotnet / arcade-services

Arcade Engineering Services
MIT License
54 stars 72 forks source link

Option of not pushing empty commits for dependency updates #3642

Open rolfbjarne opened 2 weeks ago

rolfbjarne commented 2 weeks ago

Sometimes maestro pushes empty commits for dependency updates.

Example:

xamarin/xamarin-macios@648d548 (#20721)

Our CI is optimized to only run in case certain files are modified - this means that if no files were modified, then CI won't run (for the most part at least, there are some GitHub actions that still run and produce successful checks).

This becomes a problem, because the empty commit resets all the statuses on the PR, effectively wiping out any build or results for the PR, and the green status of the PR is quite misleading: we have to look at the status for the last non-empty commit in order to determine whether a PR is truly green or not.

It seems there's a simple fix here: make maestro not push empty commits.

Would this be possible?

premun commented 2 weeks ago

Thanks for logging this.

I think this might be a regression (or broken since forever) and should potentially not happen at all.

It's very much possible but, unfortunately due to Wave 1, not sure when we will get to it at the moment.

rolfbjarne commented 2 weeks ago

I think this might be a regression (or broken since forever) and should potentially not happen at all.

This didn't happen when we first started using maestro (.NET 6 timeframe), so it's a regression (although it's been going on for a while by now, I'm not sure when it started happening).