dotnet / arcade-services

Arcade Engineering Services
MIT License
54 stars 72 forks source link

Restore and re-apply all VMR patches always #3690

Closed premun closed 1 week ago

premun commented 1 week ago

Fixes a problem found in https://github.com/dotnet/sdk/issues/41793. The problem is that if SDK is the root repo where VMR patches are stored, and SDK gets pulled into the VMR, we must restore the previous versions of those VMR patches in the SDK before the new SDK changes were merged into the VMR. This manifests in us trying to restore VMR patches that will only be added during the sync later.

The new code stops evaluating which VMR patches must be removed and strips all VMR patches always and then returns all back. So this simplifies the code a bit.

premun commented 6 days ago

Oh no, I merged the wrong PR 😅