dotnet / arcade

Tools that provide common build infrastructure for multiple .NET Foundation projects.
MIT License
672 stars 347 forks source link

Problem with script signature validation #13923

Closed MichalPavlik closed 1 year ago

MichalPavlik commented 1 year ago

Hello @epananth, MicroBuild now supports our custom key, and the signing works. But we have problem with validation of the old PS1 script.

https://dev.azure.com/dnceng/internal/_build/results?buildId=2222053&view=logs&j=fa59fe4e-195c-56fa-189b-58fd241f10dd&t=e0ea3df6-0956-547c-f7b9-9062676d48ed&l=32

The validation step is complaining about missing signature of the assembly which is only byproduct of the build and is deleted after the build. The InputFiles property for the validation is set to target just PS1 files, so I'm confused why is SignCheckTask bothering with this assembly...

pipeline: https://dev.azure.com/dnceng/internal/_git/dotnet-install-scripts?path=/azure-pipelines.yml&version=GBdev/mipavlik/bash-signing&line=79&lineEnd=80&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

Release Note Category

MichalPavlik commented 1 year ago

I'm closing the issue as I was able to resolve it.