search

dotnet / arcade

Tools that provide common build infrastructure for multiple .NET Foundation projects.
MIT License
667 stars 345 forks source link

Remove variable group - Dotnet-Blob-feed #13963

Open epananth opened 1 year ago

epananth commented 1 year ago

Dotnet-Blob-feed is no longer used in Arcade. But the product repos still reference it in their pipelines, so it's time to remove this variable group so that we don't have to maintain it.

Engineering services team is going to remove this variable group by 08/20/2023, so product teams please remove the variable group and fix your builds.

cc: @mmitche @riarenas @ilyas1974

Release Note Category

dougbu commented 1 year ago

@epananth has this been communicated to our partners❔ or, are you searching product team pipelines for UI and YAML mentions of the variable group❔

epananth commented 1 year ago

Not yet, I will this week.. I will have to change the date on this.. I kinda lost track of this after I was done with SSA last time. I will complete it this time..

chcosta commented 11 months ago

Sent mail to partners with a removal date of 11/1/2023

chcosta commented 11 months ago

In the interest of not putting anyone in a completely blocked / super impactful state, my recommendation would be to actually revoke all pipeline permissions on 11/1, and then wait until later before actually deleting the variable group. Revoking the pipeline permissions will put repos in a blocked state ("Permissions needed"). This will notify pipeline owners (assuming they look at their pipeline) and allow us to unblock them while also taking note of the dependency. I actually noticed a pipeline we own which references the variable group.

Next steps:

chcosta commented 11 months ago

After 11/1/2023, we will be removing pipeline access to the DotNet-Blob-Feed variable group. If your pipeline references the variable group, you may see a message like this when you try to run a build…

image

DotNet-Blob-Feed references were removed from Arcade in Remove vars and steps that shouldn't be necessary by mmitche · Pull Request #11577 · dotnet/arcade (github.com) which corresponds to Arcade Sdk version 8.0.0-beta.22564.8 (Arcade commit: 8df5191cc3062d2bdb0d24a7e26e6c87f9f96a9d)

If you are on an older version of Arcade, you probably still aren't relying on the DotNet-Blob-Feed variable group, but you may still have a reference to it in your yaml templates.

Mitigation steps:

Notes:

riarenas commented 11 months ago

Permissions have been removed from the variable group. I estimate we can delete this variable group at any point after 12/1 (but we might want to wait until next year)

riarenas commented 11 months ago

This variable group is used by both roslyn and F# builds. @MilenaHristova gave those permissions back, but that means this group cannot be removed yet. Throwing this back to the backlog

MilenaHristova commented 11 months ago

This variable group is used by both roslyn and F# builds. @MilenaHristova gave those permissions back, but that means this group cannot be removed yet. Throwing this back to the backlog

O no, I'm sorry. I should've told them to remove the dependency to the variable group?

riarenas commented 11 months ago

Not at all, I think you did the right thing by unblocking them! I'll just mention to examine the removal after I do some digging. Roslyn and F# have some special circumstances on how they take arcade updates.

riarenas commented 11 months ago

It just looks like they have references to the variable groups in their yaml, and not in an arcade template. I'll let the teams know to look at the remediation comment.

riarenas commented 11 months ago

This group is also... used by arcade-official. I just granted permissions once again.

riarenas commented 11 months ago

Add dotnet-interactive to the list of repos still using this.

dkurepa commented 11 months ago

The variable group wasn't removed on arcade 6.0. This is causing issues for the https://github.com/dotnet/install-scripts repos, which is using arcade 6.0.

dkurepa commented 11 months ago

In general, don't we need to remove it on 6.0 and 7.0 for servicing? @epananth

riarenas commented 11 months ago

Yep... I think this issue still needs work and investigation before we can remove permissions again. At the very least this variable group should be removed from every arcade template on every arcade branch.

MilenaHristova commented 10 months ago

dotnetfeed-storage-access-key-1 is used in dotnet release pipeline, information in https://github.com/dotnet/release/issues/709

missymessa commented 10 months ago

Current status: The variable group has been removed from release/7.0, release/8.0, main branches of Arcade.

We have some issues with removing this from release/6.0, so we'll chat about it in triage.

missymessa commented 10 months ago

Ensure that Secret Manager no longer requests for the unused secret to be rotated.

garath commented 10 months ago

Ensure that Secret Manager no longer requests for the unused secret to be rotated.

And then close this issue. We got the primary win of removing this group from Arcade main and release/8, and the tail of getting the remaining bits extracted are proving troublesome.

premun commented 10 months ago

Update from our side: I moved arcade-services onto 8.0 Arcade last week so we can remove the usage. @andriipatsula will take care of that.

premun commented 10 months ago

dnceng-shared is in the same boat as arcade-services. I believe the CI was copied from arcade-services when being created. Seems like dnceng-shared could also use a commit like this one: https://dev.azure.com/dnceng/internal/_git/dotnet-wpf-int/pullrequest/35321?_a=files https://dev.azure.com/dnceng/internal/_build/results?buildId=2308725&view=results

Its internal pipeline is stuck on waiting on permissions too but it will need a bump from 6.0 to 8.0 Arcade too. Volunteers? (I won't be able this week)

dkurepa commented 10 months ago

The arcade 6.0 validation broke on the PR that removed the variable group. I opened up a PR to revert it since we need to get https://github.com/dotnet/arcade/pull/14248 in. Revert PR: https://github.com/dotnet/arcade/pull/14257