Open mmitche opened 10 months ago
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
Assigning myself for now since I've been working on this in parallel with https://github.com/dotnet/arcade/issues/14438. The piece that I'm missing is the entitlements. I'll discuss this more when I open the draft PR since then I'll be able to point to the section of code that I think we may need to add entitlements with.
This is the current commit with the changes for signing. This commit sits on top of https://github.com/dotnet/arcade/pull/15205 and https://github.com/dotnet/arcade/pull/15206.
Some things that were unclear with these task that will need to be addressed before the changes are ready for PR:
Microsoft400
but I am unsure if this is correct.Round{round}-OSX-Cert{certificate}.proj
?Round{round}.proj
be the project filename? How does this work with signing non OSX files that use the same project filename?T-Shirt Size: S/M
Requires reworking of the current infra for signing osx extensions given this documentation: https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/19841/Additional-Requirements-for-Signing-or-Notarizing-Mac-Files?anchor=visual-studio-project-files
There are a couple interesting points here:
Our existing signing infra has us applying entitlements to dotnet, createdump, etc. I need to determine whether these entitlements have already been applied by other repos. Is it necessary to re-apply them?
It does look like entitlements are already added and do not need to be re-added. Confirming
Enable SignTool to process and and submit MacOS .pkgs for signing and notarization. Because notarization can only happen on a Mac machine, this requires https://github.com/dotnet/arcade/issues/14431 to be complete.
One place to start with this is looking at what we do in the staging pipelines.