dotnet / arcade

Tools that provide common build infrastructure for multiple .NET Foundation projects.
MIT License
671 stars 349 forks source link

Enable signing and notarization of .pkg files using SignTool #14435

Open mmitche opened 10 months ago

mmitche commented 10 months ago

Enable SignTool to process and and submit MacOS .pkgs for signing and notarization. Because notarization can only happen on a Mac machine, this requires https://github.com/dotnet/arcade/issues/14431 to be complete.

One place to start with this is looking at what we do in the staging pipelines.

dotnet-issue-labeler[bot] commented 10 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ellahathaway commented 4 weeks ago

Assigning myself for now since I've been working on this in parallel with https://github.com/dotnet/arcade/issues/14438. The piece that I'm missing is the entitlements. I'll discuss this more when I open the draft PR since then I'll be able to point to the section of code that I think we may need to add entitlements with.

ellahathaway commented 4 weeks ago

This is the current commit with the changes for signing. This commit sits on top of https://github.com/dotnet/arcade/pull/15205 and https://github.com/dotnet/arcade/pull/15206.

Some things that were unclear with these task that will need to be addressed before the changes are ready for PR:

ellahathaway commented 4 weeks ago

T-Shirt Size: S/M

Requires reworking of the current infra for signing osx extensions given this documentation: https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/19841/Additional-Requirements-for-Signing-or-Notarizing-Mac-Files?anchor=visual-studio-project-files

mmitche commented 1 day ago

There are a couple interesting points here:

Our existing signing infra has us applying entitlements to dotnet, createdump, etc. I need to determine whether these entitlements have already been applied by other repos. Is it necessary to re-apply them?

mmitche commented 1 day ago

It does look like entitlements are already added and do not need to be re-added. Confirming