Ensure we rewrite all entries, even if not signed - second attempt

dotnet / arcade

Tools that provide common build infrastructure for multiple .NET Foundation projects.

MIT License

671 stars 349 forks source link

Ensure we rewrite all entries, even if not signed - second attempt #15288

Closed ViktorHofer closed 3 days ago

ViktorHofer commented 4 days ago

When roundtripping a TarEntry from TarReader back to TarWriter, the Stream must be copied into a MemoryStream as the returned TarEntry Stream is not seekable.

Fixes https://github.com/dotnet/arcade/issues/15232 but for main

Also simplified a few code blocks and made it more readable. Tested locally.

ViktorHofer commented 3 days ago

The patch in https://github.com/dotnet/sdk/pull/45207 works as expected.