dotnet / arcade

Tools that provide common build infrastructure for multiple .NET Foundation projects.
MIT License
672 stars 347 forks source link

Remove use of .pkgproj from repos outside of dotnet/runtime #5889

Open akoeplinger opened 4 years ago

akoeplinger commented 4 years ago

See discussion in https://github.com/dotnet/arcade/pull/5818#issuecomment-668690752.

https://github.com/dotnet/llvm-project and https://github.com/dotnet/icu are using .pkgproj to produce nuget packages with (probably non-ideal) logic copied from dotnet/runtime. Those usages should be removed.

/cc @ViktorHofer @ericstj

ericstj commented 4 years ago

I don't think we're going to go into other folks repositories and remove their use of pkgproj. We can collaborate to suggest alternatives, but I don't think we should be tracking this here,.

akoeplinger commented 4 years ago

Well I don't really care where it's tracked and I'm kinda maintaining the packaging for these repos :)

akoeplinger commented 4 years ago

Just to set expectations, I will need help with replacing them as I have no idea how it's supposed to be done "the right way" 😄

ericstj commented 4 years ago

Don’t use PKGProj :). Use publicly documented pack target that’s integrated with the SDK.