Open benvillalobos opened 3 years ago
Based on some new understanding (thank you @riarenas), it appears this task wouldn't be able to gain context as to why it failed. As a standard though, MSBuild prefers that tasks log their own errors when they would return false.
@BenVillalobos I'm removing the blocking checkbox for now as I think we figured out this was a matter of using an older version of arcade that was still affected by https://github.com/dotnet/core-eng/issues/11458. We can discuss the logging for the task during triage. If updating to a newer arcade doesn't solve things, feel free to mark it blocking again.
@riarenas updating arcade resolved the issue. Thanks again!
Context
MSBuild is upgrading to Arcade 5.0 and we're hitting errors in our pipeline builds that our
nupkg
files aren't signed properly.The Problem
These errors aren't helpful, as all we see is:
c:\src\git\msbuild\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20510.1\tools\SdkTasks\SigningValidation.proj(48,5): error MSB4181: The "SignCheckTask" task returned false but did not log an error. [c:\src\git\msbuild\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20510.1\tools\SdkTasks\SigningValidation.proj]
Some sort of solution
If the task would fail, throw an error that provides context as to why it failed.
Why it's blocking
I'm not sure how to move forward migrating to arcade 5.0 because I'm not sure what's going wrong.
Extra Info
Contents of
signcheck.errors.log
Signing issues found
Contents ofsigncheck.log