Open lewing opened 2 years ago
That is not the only thing I do not like about the msi gen in arcade:
For starters people outside of the .NET Foundation (me) use the arcade to build msi installers for windows and they incorrectly get stamped with:
by default instead of their own copyright setting.
Hopefully the macos pkg gen does not have that issue as well too.
https://github.com/dotnet/arcade/blob/dfb902f38e7c68d8cd83d53f32ea174e8f3a310a/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/wix.targets#L46
.NET workload manifests need a way to generate correct msi versions but can't easily use the current _GenerateMsiVersionString wix target so we've had to duplicate the target in:
We'd like to get rid of that duplication and use shared code
cc @steveisok @joeloff @mmitche