Open akoeplinger opened 2 years ago
@akoeplinger Is this blocking things? I think for the particular case of disableComponentGovernance
we might just want to get rid of it from jobs.yml, as I don't think we ever want to be in a world where CG is disabled for an entire set of jobs.
Yeah, that makes sense. I think removing it from the top level is the best thing to do. What jobs do you need to disable CG for?
What jobs do you need to disable CG for?
I think this is related to the task not working in alpine containers, causing builds to be yellow: https://dev.azure.com/dnceng/internal/_build/results?buildId=1607090&view=results
yes exactly. it's not blocking right now since the task no longer causes an error but the warning is just noise.
Removing the property from jobs.yml sounds like a good solution.
I'm going to split this issue:
Given a .yml like this:
results in an Azure Pipelines error:
If I read it correctly this happens because this code passes along parameters from jobs.yml into the job.yml so we end up with one
disableComponentGovernance
from jobs.yml and one from thejob
: https://github.com/dotnet/arcade/blob/3cbeb243091dab28adfdcd09fc43b77112cfbe72/eng/common/templates/jobs/jobs.yml#L44-L51The same happens with the other parameters that are forwarded, like
continueOnError
etc./cc @mmitche