Remove workaround for ASP.NET Core Promethesus exporter issue when resolved

DamianEdwards commented 4 months ago

The Metrics sample is working around open-telemetry/opentelemetry-dotnet-contrib#1617 right now. These workarounds should be removed when this issue is resovled.

joperezr commented 4 months ago

@samsp-msft can you follow up in that external issue as this is broken for GA?

samsp-msft commented 1 month ago

The issue with prometheus is resolved and metrics are working with OpenTelemetry.Exporter.Prometheus.AspNetCore 1.9.0-beta.2.

However, in trying that out I realized what a mess getting prometheus to work with anything but the simplest projects is. I was trying to get it to work with testshop, and ran into issues with:

https redirection and getting prometheus to be happy with the dev cert - in the end I had to remove the https redirection
Talking between containers - and getting the ports right - the sample project uses a direct url
Configuring prometheus to scrape from each applicable container

I think to make prometheus a real story we would need to have a better solution for how it can resolve the services that it needs to pull the data from. I don't know if we can use one of the existing scrape discovery mechanisms, or if we need to add a prometheus scraping provider to apphost that can then deliver the dependency data via config modifications, but I would suggest the prometheus experience is less than ideal.

It reminds me why the dashboard is such a revolutionary experience.

mitchdenny commented 1 month ago

Moving to backlog for now. Once we are at 8.2 (very shortly) we'll make the case of what we want to bring in.

dotnet / aspire-samples

Remove workaround for ASP.NET Core Promethesus exporter issue when resolved #215