search

dotnet / aspire-samples

MIT License
560 stars 153 forks source link

Update to Aspire 8.0.2 #342

Open joperezr opened 1 week ago

joperezr commented 1 week ago

cc: @DamianEdwards @radical

radical commented 1 week ago

Can we use a property for these versions? That would be needed anyway for enabling aspire-samples CI with aspire repo.

joperezr commented 1 week ago

Can we use a property for these versions? That would be needed anyway for enabling aspire-samples CI with aspire repo.

I believe the desire is for these projects to be copy-pastable (as they are samples) so by definition they don't use any sort of central package management.

radical commented 1 week ago

Can we use a property for these versions? That would be needed anyway for enabling aspire-samples CI with aspire repo.

I believe the desire is for these projects to be copy-pastable (as they are samples) so by definition they don't use any sort of central package management.

Maybe a property in each of the csproj files then, so that it would be possible cleanly replace the versions with 8.1.0-ci(for example) on aspire CI. Or a Directory.Build.props?

DamianEdwards commented 1 week ago

We could introduce hierarchical Directory.Build.props to make it easy to set one version from the root (for cases like CI) but otherwise have each sample have a single place where the version is set. That's fine as long as each sample can be copied out and run without the rest of the repo.

radical commented 1 week ago 
Failed SamplesIntegrationTests.AppHostTests.TestEndpointsReturnOk(testEndpoints: VolumeMount.AppHost (1 resources)) [5 m 31 s]
  Error Message:
   Polly.Timeout.TimeoutRejectedException : The operation didn't complete within the allowed timeout of '00:05:00'.

.. with lots of Azure.RequestFailedException: The API version 2024-05-04 is not supported by Azurite. Please upgrade Azurite to latest version and retry. If you are using Azurite in Visual Studio, please check you have installed latest Visual Studio patch. Azurite command line parameter "--skipApiVersionCheck" or Visual Studio Code configuration "Skip Api Version Check" can skip this error.

It's a big log, and I'm not sure if I'm looking at the correct cause for the failure.

DamianEdwards commented 1 week ago

Will have to try and reproduce the issue locally I think.

joperezr commented 1 week ago

Since I'll be out for a couple of weeks, feel free to modify or close this PR as you see fit.