Closed dependabot[bot] closed 2 months ago
these JS depy updates are generally hitting some kind of conflict like this
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @vue/eslint-config-typescript@13.0.0
EXEC : npm error Found: eslint@9.6.0 [/home/runner/work/aspire-samples/aspire-samples/samples/AspireWithJavaScript/AspireJavaScript.AppHost/AspireJavaScript.AppHost.csproj]
npm error node_modules/eslint
npm error dev eslint@"^9.6.0" from the root project
npm error peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm error node_modules/@eslint-community/eslint-utils
npm error @eslint-community/eslint-utils@"^4.4.0" from @typescript-eslint/utils@7.14.1
npm error node_modules/@vue/eslint-config-typescript/node_modules/@typescript-eslint/eslint-plugin/node_modules/@typescript-eslint/utils
npm error @typescript-eslint/utils@"7.14.1" from @typescript-eslint/eslint-plugin@7.14.1
npm error node_modules/@vue/eslint-config-typescript/node_modules/@typescript-eslint/eslint-plugin
npm error @typescript-eslint/eslint-plugin@"^7.1.1" from @vue/eslint-config-typescript@13.0.0
npm error node_modules/@vue/eslint-config-typescript
npm error 1 more (@typescript-eslint/type-utils)
npm error @eslint-community/eslint-utils@"^4.2.0" from eslint@9.6.0
npm error 1 more (eslint-plugin-vue)
npm error 5 more (@vue/eslint-config-prettier, eslint-config-prettier, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^8.56.0" from @vue/eslint-config-typescript@13.0.0
npm error node_modules/@vue/eslint-config-typescript
npm error dev @vue/eslint-config-typescript@"^13.0.0" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.0
npm error node_modules/eslint
npm error peer eslint@"^8.56.0" from @vue/eslint-config-typescript@13.0.0
npm error node_modules/@vue/eslint-config-typescript
npm error dev @vue/eslint-config-typescript@"^13.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
When I pull this branch and build locally on Windows, I don't get the error. Windows leg here canceled, let's run it.
for my future reference to do a similar update locally I updated npm and node and then ran
C:\git\aspire-samples>for /f %i in ('dir /s/b package-lock.json') do (@echo %~dpi & cd %~dpi & npm update)
@radical Windows leg won't start -- perhaps it relies on a successful Linux leg first?
Also does it surprise you that dotnet build
of this branch on Windows does not have any of these node errors?
Oh it doesn't build on Windows at all? Is that long term? https://github.com/dotnet/aspire-samples/actions/runs/9739073953/workflow?pr=344#L26
If so I still have the 2nd question.
@radical Windows leg won't start -- perhaps it relies on a successful Linux leg first?
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures
jobs.<job_id>.strategy.fail-fast applies to the entire matrix. If jobs.<job_id>.strategy.fail-fast is set to true or its expression evaluates to true, GitHub will cancel all in-progress and queued jobs in the matrix if any job in the matrix fails. This property defaults to true.
Setting this to false
should help, IIUC.
There is also this but IIUC that's not what we need here:
jobs.<job_id>.continue-on-error applies to a single job. If jobs.<job_id>.continue-on-error is true, other jobs in the matrix will continue running even if the job with jobs.<job_id>.continue-on-error: true fails.
Oh it doesn't build on Windows at all? Is that long term? dotnet/aspire-samples/actions/runs/9739073953/workflow?pr=344#L26
Is Baseline 8.0.1xx
because of DOTNET_BASELINE_SDK_VERSION: '8.0.1xx'
? No idea why that was skipped. It was added in https://github.com/dotnet/aspire-samples/pull/213/ .
Fails on windows too now - https://github.com/dotnet/aspire-samples/actions/runs/9784951746/job/27016947772
Yeah, now it's failing for me too. Wonder why it didn't before.
Anyway - at some future point I/we need to figure out how to efficiently resolve these conflicts which seem common. Ideally npm would be able to figure out some working combination, presumably one exists.
@dependabot ignore eslint major version
OK, I won't notify you about version 9.x.x of eslint again, unless you unignore it.
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.
To ignore these dependencies, configure ignore rules in dependabot.yml
Bumps the all-dependencies group with 13 updates in the /samples/AspireWithJavaScript/AspireJavaScript.Vue directory:
3.4.24
3.4.31
1.6.1
1.10.3
20.12.7
20.14.9
4.5.2
5.0.5
8.0.0
9.0.0
12.0.0
13.0.0
8.56.0
9.6.0
9.19.2
9.26.0
6.1.1
6.2.0
3.1.1
3.3.2
5.3.3
5.5.2
5.0.13
5.3.2
1.8.25
2.0.24
Updates
vue
from 3.4.24 to 3.4.31Release notes
Sourced from vue's releases.
Changelog
Sourced from vue's changelog.
... (truncated)
Commits
f2acd51
release: v3.4.31746352a
fix(compiler-core): handle inline comments with undefined bindings (#11217)ad22879
test(reactivity): add a failed test for computed (#11243)b1d1f44
chore(deps): update dependency monaco-editor to ^0.50.0 (#11211)e0df985
fix: Revert "fix(reactivity): avoid infinite loop when render access a side e...6c303ea
Revert "fix(reactivity): fix side effect computed dirty level (#11183)"261fb7c
chore(deps): update dawidd6/action-download-artifact action to v6 (#11212)01ff603
chore(deps): update dependency puppeteer to ~22.12.0 (#11210)89946f8
chore(deps): update dependency typescript-eslint to ^7.13.1 (#11209)a1170db
chore(deps): update all non-major dependencies (#11207)Updates
@rushstack/eslint-patch
from 1.6.1 to 1.10.3Changelog
Sourced from
@rushstack/eslint-patch
's changelog.... (truncated)
Commits
f29305d
Bump versions [skip ci]fbcf938
Update changelogs [skip ci]1dc0e7d
[eslint-patch] Allow use of ESLint v9777e9f8
Update eslint-patch for v9dff8133
Bump versions [skip ci]fec5eaa
Update changelogs [skip ci]b5771db
Bump ESLint to ~8.57.0323fddb
Bump versions [skip ci]165cb01
Update changelogs [skip ci]fce27bb
Clean up a logging message.Updates
@types/node
from 20.12.7 to 20.14.9Commits
Updates
@vitejs/plugin-vue
from 4.5.2 to 5.0.5Release notes
Sourced from
@vitejs/plugin-vue
's releases.Changelog
Sourced from
@vitejs/plugin-vue
's changelog.... (truncated)
Commits
e74816a
release: plugin-vue@5.0.5277a3ab
fix(plugin-vue): don't inline template when__VUE_PROD_DEVTOOLS__
(#81)2848174
refactor(plugin-vue): use normalizePath from vite (#395)96c82e9
chore(deps): update upstream (#379)0a484c7
fix(deps): update all non-major dependencies (#371)997f9bb
chore(deps): replace dependency eslint-plugin-node with eslint-plugin-n ^14.0...2050ad3
chore(deps): update upstream (#367)ed4970a
fix(deps): update all non-major dependencies (#360)a28c46e
chore(deps): update upstream (#361)3f8b472
chore(plugin-vue): update options on docsUpdates
@vue/eslint-config-prettier
from 8.0.0 to 9.0.0Release notes
Sourced from
@vue/eslint-config-prettier
's releases.Changelog
Sourced from
@vue/eslint-config-prettier
's changelog.Commits
02a30df
9.0.0905aa1c
chore: update eslint-config-prettier to v9 (#18)1d6ac3d
chore: add changelogs for v7 to v8Updates
@vue/eslint-config-typescript
from 12.0.0 to 13.0.0Release notes
Sourced from
@vue/eslint-config-typescript
's releases.Commits
e0bf9da
13.0.08f7e461
ci: update actions' verions2abd17e
feat!: upgrade typescript-eslint to v7Updates
eslint
from 8.56.0 to 9.6.0Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
473d1bb
9.6.0f435566
Build: changelog update for 9.6.0b15ee30
chore: upgrade@eslint/js
@9
.6.0 (#18632)d655503
chore: package.json update for@eslint/js
release1613e2e
fix: Allow escaping characters in config patterns on Windows (#18628)13dbecd
docs: Limit search to just docs (#18627)7c78ad9
refactor: Use language.visitorKeys and check for non-JS SourceCode (#18625)e2b16e2
feat: Implement feature flags (#18516)69ff64e
refactor: Return value of applyInlineConfig() (#18623)375227f
docs: Update getting-started.md - add pnpm to init eslint config (#18599)Updates
eslint-plugin-vue
from 9.19.2 to 9.26.0Release notes
Sourced from eslint-plugin-vue's releases.
... (truncated)
Commits
516253d
9.26.056c9e3a
chore: fix leaka3c98d8
Fix checking for script setup in vue/require-typed-ref (#2427)98e030a
fix: Prevent spread operator from disabling the rule (#2456)f0aa5dc
Support MathML elements (#2457)cfad3ee
9.25.0e665b7c
Fixed false negatives for props in template invue/no-unused-properties
(#2...a4be0fc
Support Pinia methods invue/no-unused-prope... _Description has been truncated_