search

dotnet / aspire-samples

MIT License
742 stars 217 forks source link

created functions sample #523

Closed bradygaster closed 3 weeks ago

bradygaster commented 1 month ago

This includes all of the files required for the Functions + Aspire sample to work. Open to feedback!

DamianEdwards commented 1 month ago

@bradygaster this sample will need a README.md too

bradygaster commented 1 month ago

@DamianEdwards - tweaked the UX and added a readme, along with a few renames to be consistent. lmk if anything else is requisite, thanks for the review.

DamianEdwards commented 1 month ago

@bradygaster just checking, your intent was to remove the side navbar completely? This is what I see now: image

bradygaster commented 1 month ago

@DamianEdwards and @captainsafia - anything else?

bradygaster commented 4 weeks ago

@DamianEdwards and @captainsafia - i got some great updates from @IEvangelist to clean up the UX. added those and took Safia's feedback into consideration and got them both in this push.

captainsafia commented 4 weeks ago

@DamianEdwards and @captainsafia - i got some great updates from @IEvangelist to clean up the UX. added those and took Safia's feedback into consideration and got them both in this push.

Noted. @IEvangelist mentioned running into some test issues with these changes. Did https://github.com/dotnet/aspire-samples/pull/523/commits/f92eeacf53c6b425e0359042e0a65ffad5d8ee4c resolve this? I don't think it's necessary for us to use WithHostStorage in the sample code so if that works around the race condition then that is fine by me.

IEvangelist commented 4 weeks ago

@DamianEdwards and @captainsafia - i got some great updates from @IEvangelist to clean up the UX. added those and took Safia's feedback into consideration and got them both in this push.

Noted. @IEvangelist mentioned running into some test issues with these changes. Did f92eeac resolve this? I don't think it's necessary for us to use WithHostStorage in the sample code so if that works around the race condition then that is fine by me.

Yes, I removed that from the sample, and everything is again green!