dotnet / aspire-samples

MIT License
744 stars 217 forks source link

[WebToolsE2E][Aspire] Building version 9.0.0 of AspireWithPython fails with an error: " 'Aspire.Hosting.PythonAppResourceBuilderExtensions.AddPythonApp()' is for evaluation purposes only and is subject to change or removal in future updates." #527

Closed v-sherryfan closed 2 weeks ago

v-sherryfan commented 1 month ago

REGRESSION INFO: worked in main branch [Aspire 9.0.0 rc 1]

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install VS 17.12 Preview 4
  3. Install Python [3.13.0]
  4. Install Docker Desktop
  5. Install azd [1.10.3]

REPRO STEPS

  1. Clone aspire-samples repo, checkout to UpdateTo9GA branch
  2. Add aspire 9.0.0 feed/mapping to nuget.config
  3. Open samples\AspireWithPython and build

ACTUAL 'Aspire.Hosting.PythonAppResourceBuilderExtensions.AddPythonApp(Aspire.Hosting.IDistributedApplicationBuilder, string, string, string, params string[])' is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed. Image

NOTE

EXPECTED Building project without any errors.

davidfowl commented 1 month ago

This is by design, we marked the API as experimental in Aspire 9 because it's unfinished. See https://github.com/dotnet/aspire/issues/6298

davidfowl commented 1 month ago

@DamianEdwards we should update the sample to ignore the warning in source.

DamianEdwards commented 1 month ago

When the samples are updated for 9.0 GA, we will 😄 Already happened in this branch: https://github.com/dotnet/aspire-samples/blob/b9b187e7a34fdd35e0ac36601804baef28b66c1e/samples/AspireWithPython/AspireWithPython.AppHost/Program.cs#L3

DamianEdwards commented 2 weeks ago

Fixed

v-sherryfan commented 2 weeks ago

Not repro on main branch