Fix up Azure Functions sample for publishing

dotnet / aspire-samples

MIT License

742 stars 217 forks source link

Fix up Azure Functions sample for publishing #531

Closed captainsafia closed 3 weeks ago

captainsafia commented 3 weeks ago

This PR fixes up a couple of issues with the Azure Functions sample that make it unpublishable:

Enable external HTTP access on the Blazor front-end resource
Configure the appropriate roles to support Blob triggers on the Azure Functions host
Allow anonymous access to blobs in the storage account to support UI display in the Blazor front-end
Reference SkiaSharp.NativeAssets.Linux.NoDependencies package to support running SkiaSharp in Linux containers on ACA

bradygaster commented 3 weeks ago

cloned and tried deploying - worked like a champ. ship it.

DamianEdwards commented 3 weeks ago

Adding back WithHostStorage() is leading to the test issue WRT resource(s) being removed after waiting for them has started. I'll take a look at the test to see if I can refactor it to handle it.

captainsafia commented 3 weeks ago

Adding back WithHostStorage() is leading to the test issue WRT resource(s) being removed after waiting for them has started. I'll take a look at the test to see if I can refactor it to handle it.

Yes, as soon I saw the failing CI I realized I opened that can of worms again 😭. Let me know if you'd like any help or to split up the changes in this PR.

DamianEdwards commented 3 weeks ago

Wow, that worked 😮

captainsafia commented 3 weeks ago

Wow, that worked 😮

Should we kick CI a couple of times to sanity check?

DamianEdwards commented 3 weeks ago

Should we kick CI a couple of times to sanity check?

Yeah I don't even think the logic I added is being hit but instead it's working because now Start and Wait are awaited sequentially now. I previously had to start them in parallel based on discussions I had with @davidfowl but I can't remember the details and it's seemingly passing now anyway.