dotnet / aspire-samples

MIT License
737 stars 214 forks source link

Add a test to verify publish manifests #572

Open DamianEdwards opened 1 week ago

DamianEdwards commented 1 week ago

From #570

Out of curiosity, if we wouldn't have ingested 9.0 GA yet (with the fixes), and we tried doing these changes, would a test(s) have failed as part of CI in this PR? If not, should it and should we add a test for it?

Not for this specific change, as it relates to publishing. We don't have any tests that verify the output of publish currently. The cheapest thing we could do is add tests to verify the manifests generated are what's expected. Of course any change that impacts the manifest would then require the "expected state" manifest to be updated. Logged https://github.com/dotnet/aspire-samples/issues/572 to track that idea.