search

dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.83k stars 457 forks source link

Some Pomelo tests had to be disabled for in vNext branch #2033

Open joperezr opened 9 months ago

joperezr commented 9 months ago

When ingesting the latest changes from main branch into vNext (which is the branch where we have the 9.0 work), some of the Pomelo tests started to fail with:

System.MissingMethodException : Method not found: 'Void Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer..ctor(Microsoft.EntityFrameworkCore.Storage.IRelationalTypeMappingSource, Microsoft.EntityFrameworkCore.Migrations.IMigrationsAnnotationProvider, Microsoft.EntityFrameworkCore.Update.Internal.IRowIdentityMapFactory, Microsoft.EntityFrameworkCore.Update.Internal.CommandBatchPreparerDependencies)'.

@eerhardt helped taking a closer look, and it seems like the issue is that Pomelo depends on an EF API which has been removed from 9.0, which is causing the test to fail when running against 9.0 versions of EF. Here is the method in question: https://github.com/dotnet/efcore/commit/d8e9f61507c4be7321051e17ed57794c0c743272#diff-61230962b4a1d0cd88337523544ae46181e41f589bd4af21fc3dc19f5ceb0e77R57

Tests had to be disabled in this PR: https://github.com/dotnet/aspire/pull/1859 but this issue is meant to track re-enabling them once Pomelo ships a new version that is targeting 9.0 versions of EF and has addressed the breaking change.

cc: @bgrainger

bgrainger commented 9 months ago

I reported this problem to the Pomelo project: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1834.