search

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
3.63k stars 409 forks source link

Resource grid: Use "Logs" rather than "View" in the logs column #2148

Closed drewnoakes closed 6 days ago

drewnoakes commented 7 months ago

A few ideas for improvements to this part of the table:

image

The "Logs" and "Details" columns both contain "View" buttons. If logs column buttons read "Logs", it'd be easier to know which button to click when scanning left-to-right from the resource name at the far side of the table.

As it stands, you have to scan left-to-right, then up the table, then back down. If you have many resources, it can be a long way to the top, and you can lose track of which row you were on, so scan back left again to validate.

image

kvenkatrajan commented 6 months ago

@leslierichardson95 thoughts on verbiage here?

leslierichardson95 commented 6 months ago

I agree the name should be changed from "View" to something else, but I feel like just "Logs" doesn't differentiate from the Logs header all that much (I'd suggest "view logs" but that would take up more space). That said, we can go with "Logs" until one of us comes up with something better. :)

davidfowl commented 6 months ago

Assigning to you @leslierichardson95

kvenkatrajan commented 5 months ago

@leslierichardson95 moving this to preview 6 - please confirm verbiage.

leslierichardson95 commented 4 months ago

For now, let's replace "View" with "logs" and "Details" and make sure the a11y tooltips give specific details about what resource that particular link is corresponding to.

davidfowl commented 1 week ago

Is this still relevant now that we have https://github.com/dotnet/aspire/pull/5516?

drewnoakes commented 6 days ago

We no longer need this.