dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
2.99k stars 283 forks source link

WithBindMount: create source directory (podman) #3946

Open tmds opened 2 weeks ago

tmds commented 2 weeks ago

One distinction between podman and docker for bind mounts is that docker will create the specified path if it does not exist while podman will fail if it does not exist.

It would be nice if the Aspire orchestrator would create the directory when the orchestrator is podman so this difference doesn't bubble up and requires the user to handle it in the AppHost.

davidfowl commented 2 weeks ago

@karolz-ms Where do you think this logic should go?

karolz-ms commented 2 weeks ago

I agree with @tmds, having this logic in the orchestrator makes sense