search

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
2.98k stars 283 forks source link

[release/8.0] Rename WithContainerRunArgs to WithContainerRuntimeArgs to reduce potential confusion #3952

Closed danegsta closed 2 weeks ago

danegsta commented 2 weeks ago

Backport of #3950 to release/8.0

Customer Impact

Original API name for WithContainerRunArgs was causing user confusion. We received a request to rename in order to clarify that this is for providing arguments to the container host when running a container, not additional commands to run inside the container at startup. This is a breaking change, but this is an advanced API intended to be used only in specific scenarios.

Testing

Aspire unit tests

Risk

Low

Regression

No

Microsoft Reviewers: Open in CodeFlow
danegsta commented 2 weeks ago

Doc comments have been updated

eerhardt commented 2 weeks ago

Doc comments have been updated

Can these be ported to main?