dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
2.98k stars 280 forks source link

[release/8.0] Set an upper bound on RabbitMQ dependency #3973

Closed eerhardt closed 2 weeks ago

eerhardt commented 2 weeks ago

Backport of #3972 to release/8.0

Customer Impact

RabbitMQ.Client v7 has many public API breaking changes. So many that our component doesn't even load with the 7.0-alpha releases. Setting a limit on our dependency means that customers will understand they can't use the 7.0 packages with our component.

Testing

Automated tests passing in the repo. I also ran dotnet pack .\src\Components\Aspire.RabbitMQ.Client\ and inspected the resulting nuget package has the right dependency version:

image

Risk

Low. We are depending on the same version. Just limiting to what versions we allow users to move to when using our component.

Regression?

No


Version 7 has binary breaking changes that cause the Aspire.RabbitMQ.Client component to fail loading with a MissingMethodException.

Contributes to #3956

Microsoft Reviewers: Open in CodeFlow