search

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
2.99k stars 283 forks source link

Removing IVT where possible Attempt 2 #3982

Closed Zombach closed 1 week ago

Zombach commented 2 weeks ago

https://github.com/dotnet/aspire/issues/3949

Made some minor edits and also cleaned up IVT if possible.

Microsoft Reviewers: Open in CodeFlow
Zombach commented 2 weeks ago

@eerhardt I hope it will be better this way

davidfowl commented 2 weeks ago

IVT is fine for tests. We don't want many of these APIs to be public. Each of these projects should have their own test project instead of all using the same test project.

@eerhardt we shouldn't be removing IVT to our tests, just between product code.

eerhardt commented 2 weeks ago

we shouldn't be removing IVT to our tests

We don't need to use IVT just to share a couple constant strings, like the docker image name and tag. Many of these tests just need to share the constant strings, and we can just compile them into the tests, like we do elsewhere.

For more complicated things we can leave IVT.

eerhardt commented 1 week ago

Thanks for the contribution!