[release/8.0] Remove `isReadOnly` argument from `WithDataVolume` and `WithDataBindMount`

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET

https://learn.microsoft.com/dotnet/aspire

MIT License

2.98k stars 280 forks source link

[release/8.0] Remove `isReadOnly` argument from `WithDataVolume` and `WithDataBindMount` #4001

Closed mitchdenny closed 2 weeks ago

mitchdenny commented 2 weeks ago

Customer Impact

The isReadOnly flag was default to true. But even if it defaulted to false it still doesn't work with Oracle. Rather than expose an argument that doesn't work we removed it.

Testing

The feature as it existed was not tested in the repo (because it didn't work). Existing test coverage passes though.

Risk

Low.

Regression?

Microsoft Reviewers: Open in CodeFlow

davidfowl commented 2 weeks ago

Looks like a bad backport.

danmoseley commented 2 weeks ago

Change looks a bit large 😀

danmoseley commented 2 weeks ago

fixed target branch

mitchdenny commented 2 weeks ago

fixed target branch

If I don't mistarget the branch when I do a manual backport you know I've been replaced by aliens.

danmoseley commented 2 weeks ago

That's what an alien would say, though..