search

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
3.66k stars 417 forks source link

EndpointReference always resolves to container host when evaluated in context of a container resource #4038

Open DamianEdwards opened 4 months ago

DamianEdwards commented 4 months ago

EndpointReference always resolves to a URI that uses the ContainerHost property when evaluated in the context of a container resource, but sometimes the endpoint address using the natural host (i.e. localhost) is required.

For example, in the eShop workshop, a Keycloak container is used as the IDP. This resource requires the addresses of the web apps using the IDP for federated authentication via OIDC. It actually needs the addresses in two formats:

  1. Resolvable by the IDP itself, i.e. the container host version
  2. Resolvable by users in the OIDC flows the IDP and web app clients are part of, i.e. the localhost version

This is because as part of the various OIDC flows, the IDP needs to verify that requests originate from URLs allowed for the configured client apps (the non-container-host address), but in some cases it also needs to actually make calls to the client apps (the container-host address).

In the workshop app, I had to reconstruct the non-container-host version of the address manually so that it could be injected into the IDP resource: https://github.com/dotnet-presentations/eshop-app-workshop/blob/66226ea402e0d2cb60c52a3d893414e2947525b3/src/eShop.AppHost/Program.cs#L48-L64

We should make it possible to specify which host property is used when an EndpointReference is resolved.

davidfowl commented 4 months ago

Yes we need a better way to opt-out of container host rewriting for endpoint references.