dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
3.35k stars 345 forks source link

Add Service Bus Administration Client API #431

Open eerhardt opened 8 months ago

eerhardt commented 8 months ago

Today we expose a ServiceBus API for registering the ServiceBusClient in DI. But not one for registering the ServiceBusAdministrationClient. We should add an extension method for registering the admin client as well.

namespace Microsoft.Extensions.Hosting;

public static class AspireServiceBusExtensions
{
+    public static void AddAzureServiceBusAdministrationClient(
+        this IHostApplicationBuilder builder,
+        string connectionName,
+        Action<AzureMessagingServiceBusSettings>? configureSettings = null,
+        Action<IAzureClientBuilder<ServiceBusAdministrationClient, ServiceBusAdministrationClientOptions>>? configureClientBuilder = null)
davidfowl commented 5 months ago

Do we still want to do this? It's required for eShop.

cc @BrennanConroy

eerhardt commented 5 months ago

In my opinion, this isn't a "must have". Users can easily do this themselves, like we do in eshop:

https://github.com/Azure-Samples/eShopOnAzure/blob/75105b61c3145e3752ac402349c5927b62437ee9/src/EventBusServiceBus/ServiceBusDependencyInjectionExtensions.cs#L34-L49

NWessel commented 3 weeks ago

This didn't make it into 8.0 i guess?

davidfowl commented 3 weeks ago

No, this was deprioritized.