search

dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.82k stars 453 forks source link

`aspire`, and `aspire-starter` templates fail when the name includes unicode characters on Windows #4555

Open radical opened 4 months ago

radical commented 4 months ago

Creating aspire, or aspire-starter templates which have a .sln file fail to create when the name includes unicode characters:

dotnet new aspire -o "aspire 😀" Screenshot 2024-06-17 at 16 48 54

This works when using templates that generate individual projects though, for example aspire-nunit:

dotnet new aspire-nunit -o "aspire 😀" Screenshot 2024-06-17 at 16 50 24

This fails only on Windows.

cc @DamianEdwards

Edit: this was found in a test using the name aspire_龦唉丂荳_㐁ᠭ_ᠤསྲིདخەلꌠ_1ᥕ_😀.

DamianEdwards commented 4 months ago

This matches what I found when we looked at this last time. Do we know if .sln files even support unicode characters on Windows?

radical commented 4 months ago

This matches what I found when we looked at this last time. Do we know if .sln files even support unicode characters on Windows?

I can create a dotnet new sln -o "test-sln 😀", and then add manually add a aspire-apphost project:

Screenshot 2024-06-17 at 18 31 39 Screenshot 2024-06-17 at 18 33 08
DamianEdwards commented 4 months ago

Ah ok good to know.