search

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
3.63k stars 408 forks source link

Failing test `Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme` #4851

Closed radical closed 1 week ago

radical commented 2 months ago

Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2492446&view=ms.vss-test-web.build-test-results-tab&runId=53858631&resultId=100204&paneView=debug

  Failed Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme [10 s]
  Error Message:
   Microsoft.Playwright.PlaywrightException : Locator expected to be visible 
Call log:
  - LocatorAssertions.ToBeVisibleAsync with timeout 5000ms
  - waiting for GetByText("TestResource")
  Stack Trace:
     at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, FrameExpectOptions expectOptions, Object expected, String message) in /_/src/Playwright/Core/AssertionsBase.cs:line 84
   at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, ExpectedTextValue[] expectedText, Object expected, String message, FrameExpectOptions options) in /_/src/Playwright/Core/AssertionsBase.cs:line 64
   at Aspire.Dashboard.Tests.Integration.Playwright.PlaywrightFixture.GoToHomeAndWaitForDataGridLoad(IPage page) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/PlaywrightFixture.cs:line 28
   at Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.<AppBar_Change_Theme>b__1_0(IPage page) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs:line 25
   at Aspire.Dashboard.Tests.Integration.Playwright.PlaywrightTestsBase.RunTestAsync(Func`2 test) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/PlaywrightTestsBase.cs:line 27
   at Aspire.Dashboard.Tests.Integration.Playwright.PlaywrightTestsBase.RunTestAsync(Func`2 test) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/PlaywrightTestsBase.cs:line 31
   at Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme() in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs:line 23
--- End of stack trace from previous location ---

This failed earlier also - https://dev.azure.com/dnceng-public/public/_build/results?buildId=735297&view=results

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "waiting for GetByText(\"TestResource\")",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: :mag_right: https://dev.azure.com/dnceng/internal/_build/results?buildId=2492446 Error message validated: [waiting for GetByText("TestResource")] Result validation: :white_check_mark: Known issue matched with the provided build. Validation performed at: 7/11/2024 1:42:31 AM UTC

Report

Build Definition Test Pull Request
771348 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5087
771310 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5168
771302 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5201
771281 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5240
770989 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5201
770585 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5236
2511721 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
770078 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5018
2510728 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
2507561 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
2507219 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
763318 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#5123
2504407 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
2504341 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
2502563 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme
746566 dotnet/aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme dotnet/aspire#4925
2497429 dotnet-aspire Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 9 17
radical commented 1 month ago

@adamint could you please disable this test till it is fixed?

sebastienros commented 1 month ago

Multiple occurences today

  Failed Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme [7 s]
  Error Message:
   Microsoft.Playwright.PlaywrightException : Locator expected to be visible 
Call log:
  - LocatorAssertions.ToBeVisibleAsync with timeout 5000ms
  - waiting for GetByText("TestResource")
  Stack Trace:
     at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, FrameExpectOptions expectOptions, Object expected, String message) in /_/src/Playwright/Core/AssertionsBase.cs:line 84
   at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, ExpectedTextValue[] expectedText, Object expected, String message, FrameExpectOptions options) in /_/src/Playwright/Core/AssertionsBase.cs:line 64
   at Aspire.Dashboard.Tests.Integration.Playwright.PlaywrightFixture.GoToHomeAndWaitForDataGridLoad(IPage page) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/PlaywrightFixture.cs:line 28
   at Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.<AppBar_Change_Theme>b__1_0(IPage page) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs:line 25
   at Aspire.Dashboard.Tests.Integration.Playwright.PlaywrightTestsBase.RunTestAsync(Func`2 test) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/PlaywrightTestsBase.cs:line 27
   at Aspire.Dashboard.Tests.Integration.Playwright.PlaywrightTestsBase.RunTestAsync(Func`2 test) in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/PlaywrightTestsBase.cs:line 31
   at Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme() in /_/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs:line 23

I will disable it

sebastienros commented 1 month ago

@radical there is [ActiveIssue("https://github.com/dotnet/aspire/issues/4623", typeof(PlaywrightProvider), nameof(PlaywrightProvider.DoesNotHavePlaywrightSupport))] on the class, should it still be running?

radical commented 1 month ago

@radical there is [ActiveIssue("https://github.com/dotnet/aspire/issues/4623", typeof(PlaywrightProvider), nameof(PlaywrightProvider.DoesNotHavePlaywrightSupport))] on the class, should it still be running?

That one will only skip the tests on OSes where we don't have playwright support right now, which is Linux. But it looks like the test is still failing on Windows, so disabling it till it is fixed makes sense.