[tests] More Conformance tests should use `Testcontainers` - Githubissues

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET

https://learn.microsoft.com/dotnet/aspire

MIT License

3.63k stars 408 forks source link

[tests] More Conformance tests should use `Testcontainers` #5254

Open radical opened 1 month ago

radical commented 1 month ago

.. similar to how others do this.

https://github.com/dotnet/aspire/blob/44a60c18d9d77110ca0aa3b753476510e4823eb2/tests/Aspire.StackExchange.Redis.Tests/RedisContainerFixture.cs#L11-L43 https://github.com/dotnet/aspire/blob/44a60c18d9d77110ca0aa3b753476510e4823eb2/tests/Aspire.StackExchange.Redis.Tests/ConformanceTests.cs#L18-L19

Currently any tests that need to connect get skipped with Unable to connect to server.

[ ] Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests.
[ ] Qdrant (https://github.com/testcontainers/testcontainers-dotnet/issues/992)
[x] ~~RabbitMq~~ (already using testcontainers, see https://github.com/dotnet/aspire/issues/5254#issuecomment-2284325181)

cc @eerhardt @sebastienros @joperezr

eerhardt commented 1 month ago

Qdrant

See https://github.com/testcontainers/testcontainers-dotnet/issues/992

RabbitMq

RabbitMQ is already using testcontainers:

https://github.com/dotnet/aspire/blob/fecfe0ac15c24de0d569714e64d255efd9a42332/tests/Aspire.RabbitMQ.Client.Tests/RabbitMQContainerFixture.cs#L34-L38