Dashpages UX improvements

dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps

https://learn.microsoft.com/dotnet/aspire

MIT License

3.8k stars 450 forks source link

Dashpages UX improvements #5347

Open samsp-msft opened 2 months ago

samsp-msft commented 2 months ago

Looking at the feature so far, I think we should make some subtle UX changes to the implementation:

[x] Create a separate logical section for DashPages from All Metrics
[x] Remove the description field from each metric and reduce the amount of vertical space in the title of each metric panel
[ ] Replace the filter panel on each metric with a dropdown in the title bar of each metric view. Clicking the button will show either a popup or side panel with the filter UI for controlling the view.

Q: If you change the filter view for a dashpage - how long does that persist for? If you switch dashpage and come back are the filters still applied? If you switch to another resource will that have the same view. I think today that switching away will reset the views. We should have a decision on the level of persistence, and have an ability to reset the view.

samsp-msft commented 2 months ago

@drewnoakes FYI

@leslierichardson95 we should have a review with UX team pretty soon

@JamesNK - do you have thoughts about the filtering persistence?

leslierichardson95 commented 2 months ago

@drewnoakes FYI

@leslierichardson95 we should have a review with UX team pretty soon

@JamesNK - do you have thoughts about the filtering persistence?

@drewnoakes @samsp-msft @jamesNK If all or some of you are free, there's a UX office hour we can go to on Thursday .

adamint commented 2 months ago

Q: If you change the filter view for a dashpage - how long does that persist for? If you switch dashpage and come back are the filters still applied? If you switch to another resource will that have the same view. I think today that switching away will reset the views. We should have a decision on the level of persistence, and have an ability to reset the view.

No, the filters will not still be applied after switching dashpages. Any decision on persistence must take into consideration single metric pages as well. For example, if you are in a dashpage that includes metric A, and then navigate to metric A's single metric view.

adamint commented 2 months ago

@samsp-msft I see that you kept the padding to the left of the individual dashpages to keep parity with the rest of the tree-view, but I would suggest that be removed, as the dashpages are top-level items, not children, here.

drewnoakes commented 2 months ago

Create a separate logical section for DashPages from All Metrics

I don't think the extra level of navigation here adds much. And when no dashpages are configured (or none are available due to missing metrics), the extra level will be redundant.

Remove the description field from each metric and reduce the amount of vertical space in the title of each metric panel

This is being tracked in #5287.

Replace the filter panel on each metric with a dropdown in the title bar of each metric view.

Also tracked in #5287.

how long does that persist for?

Can we make an issue that's just tracking filter persistence please? That's a new feature and needs to be considered in the context of non-dashpage metrics too.