search

dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
3.7k stars 423 forks source link

Enable Tracing for RabbitMQ Component when we move to their v7 #562

Open eerhardt opened 11 months ago

eerhardt commented 11 months ago

Once we have a build of RabbitMQ.Client with https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1261, we will need to enable and document the "RabbitMQ.Client" ActivitySource for our component.

One thing to note is that we added our own ActivitySource for the connection retries we do:

https://github.com/dotnet/aspire/blob/4032b57cf197184214362a8cc6b829c3b557821c/src/Components/Aspire.RabbitMQ.Client/AspireRabbitMQExtensions.cs#L23-L24

We should think about how to rectify the 2 activity sources in the future. One possibility is that once https://github.com/open-telemetry/semantic-conventions/issues/454 is completed, we might not need our own ActivitySource for tracing the connection tries.

davidfowl commented 8 months ago

Moving into preview milestone @eerhardt

eerhardt commented 7 months ago

Moving to backlog, as RabbitMQ doesn't have a stable v7 package yet. We can do this when we update for the v7 version.

davidfowl commented 3 weeks ago

Is there a new package yet?

eerhardt commented 3 weeks ago

Is there a new package yet?

https://www.nuget.org/packages/RabbitMQ.Client/

Latest version is 7.0.0-rc.9

mr-nuno commented 2 weeks ago

Trying to get tracing from the Aspire.RabbitMQ.Client but without luck. Is this not supported with the 6.8.1 version of the RabbitMQ.Client or am I doing something wrong....as usual :-)

eerhardt commented 2 weeks ago

Is this not supported with the 6.8.1 version of the RabbitMQ.Client or am I doing something wrong....as usual :-)

It is not supported in the v6.x versions of RabbitMQ.Client. It was implemented in https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1261, which was merged into the v7 branch. v7 hasn't released stable yet.