search

dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.92k stars 479 forks source link

Flaky Test: Aspire.Hosting.Elasticsearch.Tests.ElasticsearchFunctionalTests.VerifyWaitForOnElasticsearchBlocksDependentResources #5844

Open davidfowl opened 2 months ago

davidfowl commented 2 months ago

https://github.com/dotnet/aspire/pull/5380/checks?check_run_id=30500082320

Trx: Aspire.Hosting.Elasticsearch.Tests.zip

JamesNK commented 2 months ago

Another one: https://dev.azure.com/dnceng-public/public/_build/results?buildId=815350&view=results

radical commented 2 months ago

This test is using two instances of Elasticsearch. Does the dependentresource need to be Elasticsearch? Couldn't it be anything much lighter?

https://github.com/dotnet/aspire/blob/46b19a5d1bcf0dce9a15c5bb6a30a932241e2adc/tests/Aspire.Hosting.Elasticsearch.Tests/ElasticsearchFunctionalTests.cs#L219-L223

davidfowl commented 2 months ago

This was my discussion with @mitchdenny last night about this test.

BTW I realized why logs aren't' showing up and will have a change soon.

mitchdenny commented 1 month ago

dependingresource can be any other small container. I've used nginx for this purpose frequently.