dotnet / aspire

An opinionated, cloud ready stack for building observable, production ready, distributed applications in .NET
https://learn.microsoft.com/dotnet/aspire
MIT License
3.68k stars 420 forks source link

Direct link to console log doesn't refresh logs #5864

Closed sebastienros closed 1 hour ago

sebastienros commented 1 day ago

Is there an existing issue for this?

Describe the bug

When using the main branch on eShop, the link "View Console Logs" opens a new page but the log remains empty. It's only when we use the drop down list to select another resource that the logs show up.

image

image

It reproes for every resource, and repeats every time we open the logs using the same link.

Refreshing the page also fixes the issue.

Expected Behavior

The logs should refresh by themselves.

Steps To Reproduce

Use eShop with the Aspire main branch packages. Haven't tries with the local playground apps.

Exceptions (if any)

No response

.NET Version info

No response

Anything else?

No response

davidfowl commented 1 day ago

@JamesNK the console logs UI might need some playwright tests. We seem to regress this behavior pretty often

JamesNK commented 1 day ago

@sebastienros Are you rebased on the latest source code? This was recently fixed.

JamesNK commented 2 hours ago

I talked with @sebastienros and he said this error was on his branch. I'm pretty sure this is just a case of running code that doesn't have an earlier fix.